Skip to content

Golang Profiler — adds memory profiling, improves cpu profiling #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petethepig merged 40 commits into from
Apr 25, 2021
Merged

Golang Profiler — adds memory profiling, improves cpu profiling #146

petethepig merged 40 commits into from
Apr 25, 2021

Conversation

@petethepig
Copy link
Collaborator

@petethepig petethepig commented Mar 31, 2021 •
edited
Loading

  • adds support for memory profiling
  • improves cpu profiling by using pprof

@github-actions github-actions bot requested a review from Rperry2174 March 31, 2021 02:30
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #146 (ae166de) into main (35b4dca) will increase coverage by 0.03%.
The diff coverage is 52.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   57.30%   57.33%   +0.03%     
==========================================
  Files          69       72       +3     
  Lines        2672     2894     +222     
==========================================
+ Hits         1531     1659     +128     
- Misses       1021     1099      +78     
- Partials      120      136      +16
Impacted Files Coverage Δ
pkg/agent/profiler/profiler.go 0.00% <0.00%> (ø)
pkg/agent/selfprofile.go 0.00% <0.00%> (ø)
pkg/agent/spy/spy.go 5.00% <0.00%> (-4.09%) ⬇️
pkg/agent/upstream/direct/direct.go 0.00% <0.00%> (ø)
pkg/cli/usage.go 10.26% <0.00%> (ø)
pkg/server/controller.go 41.00% <ø> (ø)
pkg/server/render.go 0.00% <0.00%> (ø)
pkg/storage/tree/flamebearer.go 100.00% <ø> (ø)
pkg/structs/transporttrie/merge.go 100.00% <ø> (ø)
pkg/util/slices/contains.go 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b4dca...ae166de. Read the comment docs.

@petethepig petethepig changed the title test Testing jenkins integration Mar 31, 2021
@petethepig petethepig changed the title Testing jenkins integration go-spy improvements Apr 7, 2021
@petethepig petethepig changed the title go-spy improvements gospy improvements Apr 7, 2021
@mrowland7 mrowland7 mentioned this pull request Apr 8, 2021
Closed
@petethepig petethepig changed the title gospy improvements Big golang profiler changes Apr 25, 2021
@petethepig petethepig changed the title Big golang profiler changes Golang Profiler — adds memory profiling, improves cpu profiling Apr 25, 2021
@petethepig petethepig merged commit 704fcfb into main Apr 25, 2021
@petethepig petethepig deleted the gospy-improvements branch April 25, 2021 22:10
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
@joey-grafana
Base flamegraph visualisation (#146)
cc29c14 
* Base flamegraph visualisation

* Remove function declaration

* Convert indentation to spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rperry2174 Rperry2174 Awaiting requested review from Rperry2174

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@petethepig