fix: make adhoc table fit width #1591
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.63% // Head: 66.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
- Coverage 66.63% 66.53% -0.09%
==========================================
Files 147 148 +1
Lines 5004 5031 +27
Branches 1161 1165 +4
==========================================
+ Hits 3334 3347 +13
- Misses 1665 1679 +14
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/create-server |
|
/create-server |
3 similar comments
|
/create-server |
|
/create-server |
|
/create-server |
eh-am
left a comment
eh-am
left a comment
There was a problem hiding this comment.
I like having the names fully visible, specially if you have a bunch of profiles (.cpu, .mutex, .inuse_objects) that would be all trimmed to rideshare-app-golang..., but from design purposes I guess it makes sense making it "prettier".
| ), | ||
| }, | ||
| { value: profile.updatedAt }, | ||
| { value: format(parseISO(profile.updatedAt), 'yyyy-MM-dd') }, |
There was a problem hiding this comment.
@Rperry2174 Not sure I understand the reasoning behind this. What if I am uploading multiple files (via adhoc command for example) in a short interval (minutes) and I am basing off that info to navigate through my files.
There was a problem hiding this comment.
sounds good for time lets do this format:
Lets add one more column with the suffix:
cpu, mutex, inuse_objects, etc
|
/create-server |
|
updated PR description |
Screen.Recording.2022-10-05.at.15.43.02.mov |
|
/create-server |
1 similar comment
|
/create-server |
|
Closes #1338 |
|
/create-server |
4 participants
Brief
Changes
titlespan attribute) to Filename cellsadd suffix column, thesuffixvalue should be part of/api/adhoc/v1/profilesreponseConcerns
FileNames column values are hidden when screen width is small (thats not a problem since we are adding suffix column?)