test: Rerun failed go tests #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20250219_retry-failed-tests
branch
from
3477d1f to
740cd0b
Compare
I am a bit conflicted, as we are seeing a fair bit of test failures. This change will obvisouly help getting PRs merged quicker, but it might also lead to a downward slope in terms of test quality.
simonswine
force-pushed
the
20250219_retry-failed-tests
branch
from
740cd0b to
cdd3658
Compare
kolesnikovae
approved these changes
Feb 21, 2025
Collaborator
kolesnikovae
left a comment
kolesnikovae
left a comment
There was a problem hiding this comment.
LGTM
Thanks for adding this! I agree with your reasoning
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
I am a bit conflicted, as we are seeing a fair bit of test failures. This change will obvisouly help getting PRs merged quicker, but it might also lead to a downward slope in terms of test quality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a bit conflicted, as we are seeing a fair bit of test failures. This change will obvisouly help getting PRs merged quicker, but it might also lead to a downward slope in terms of test quality.
See #3923