Skip to content

fix: No data for format=dot queries, should not result in a 500 #4675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonswine merged 1 commit into from
Dec 9, 2025
Merged

fix: No data for format=dot queries, should not result in a 500 #4675

simonswine merged 1 commit into from
Dec 9, 2025

Conversation

@simonswine
Copy link
Contributor

@simonswine simonswine commented Dec 8, 2025 •
edited
Loading

Summary

Fixes a bug where queries using format=dot would return a 500 error when no data is available, instead of returning an empty/valid response.

Changes

  • Updated pkg/querier/http.go to handle empty data scenarios for dot format queries
  • Added comprehensive test coverage in pkg/querier/http_test.go to verify the fix

Test plan

  • Added unit tests verifying that empty data responses return appropriate status codes instead of 500 errors

@simonswine simonswine requested a review from marcsanmi as a code owner December 8, 2025 17:35
@simonswine simonswine merged commit f85cf5c into main Dec 9, 2025
21 checks passed
@simonswine simonswine deleted the 20251208_empty-dot-result branch December 9, 2025 08:25
simonswine added a commit that referenced this pull request Dec 9, 2025
@simonswine
fix: No data for format=dot queries, should not result in a 500 (#4675)
3989806
@simonswine simonswine mentioned this pull request Dec 9, 2025
Merged
simonswine added a commit that referenced this pull request Dec 9, 2025
@simonswine @korniltsev-grafanista
Update weekly f148 with fixes (#4678)
276a17d 
* profilecli(canary): do not check for service.name label (#4677)

* fix: No data for format=dot queries, should not result in a 500 (#4675)

---------

Co-authored-by: korniltsev-grafanista <anatoly.korniltsev@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@marcsanmi marcsanmi Awaiting requested review from marcsanmi marcsanmi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonswine @cyriltovena