helm: update chart for v2.0 breaking changes#5076
Merged
simonswine merged 8 commits intografana:mainfrom Apr 17, 2026
Merged
Conversation
simonswine
force-pushed
the
20260417_pyroscope-v2-breaking-fixes
branch
from
0ebacd2 to
fd4d206
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aleks-p
approved these changes
Apr 17, 2026
marcsanmi
approved these changes
Apr 17, 2026
| - "-metastore.address=kubernetes:///pyroscope-dev-metastore-headless.$(NAMESPACE_FQDN):9095" | ||
| - "-enable-query-backend=true" | ||
| - "-architecture.storage=v2" | ||
| - "-enable-query-backend-from=auto" |
Contributor
There was a problem hiding this comment.
Is this only here for dual mode, isn't it?
Contributor
Author
There was a problem hiding this comment.
Yeah trued and it is now also the default, so I can remove it
Contributor
Author
|
Helm ci will fail until there is a tagged v2.0.0 |
simonswine
force-pushed
the
20260417_pyroscope-v2-breaking-fixes
branch
from
ea23a44 to
e56c350
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit e56c350. Configure here.
simonswine
force-pushed
the
20260417_pyroscope-v2-breaking-fixes
branch
from
e56c350 to
3dc8ba5
Compare
Align the Helm chart with the binary changes from 3a68604: - Replace removed `all.enable-v1-write-path`/`all.enable-v1-read-path` flags with the new `-architecture.storage=v1|v2|v1-v2-dual` flag - Add explicit `-write-path=ingester` for v1-only mode; the binary default changed from `ingester` to `segment-writer` so without this all v1 writes would be routed to the segment-writer and fail - Remove `PYROSCOPE_V2_EXPERIMENT` env var, which was removed from the binary and no longer has any effect - Remove explicit `-storage.backend=filesystem`; filesystem is now the default storage backend - Remove explicit `-enable-query-backend=true`; it now defaults to true - Remove `/data-shared` volume mount; the new default filesystem dir `./data/v2/shared` falls naturally under the existing `/data` PVC mount - Remove `migration.queryBackend` value (rendered flag no longer exists) - Remove `persistence.shared` value stanza (mount no longer used)
The write-path/architecture.storage validation runs at startup for every component, not only the distributor. Without an explicit flag all non-v2 pods would fail to start because the binary default changed to segment-writer.
…uto values The flag is only meaningful during migration when both v1 and v2 storage are active. Skip it for pure v2 deployments, and skip it when the value is "auto" since that is already the binary default.
The queryBackend boolean was removed from values.yaml; the query backend is always enabled when v2 storage is active, so remove the dead branch.
The write-path.segment-writer-weight flag was hardcoded to 1, silently ignoring the architecture.storage.migration.segmentWriterWeight value from values.yaml.
Same issue as segmentWriterWeight: the ingesterWeight value from values.yaml was never forwarded to the binary in combined mode.
Point CI chart installation at the snapshot image built from commit 3a68604 which introduced the -architecture.storage flag.
The v prefix was hardcoded, producing vmain-171db75 for snapshot appVersions. Only prepend v when appVersion starts with a digit (i.e. is a semver tag).
simonswine
force-pushed
the
20260417_pyroscope-v2-breaking-fixes
branch
from
3dc8ba5 to
1243659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the Helm chart with the binary breaking changes from 3a68604 (Pyroscope OSS v2.0).
ingestertosegment-writer; without explicit-write-path=ingesterall v1 write traffic would be routed to the segment-writer and fail. Applied to all components (not just distributor) since the validation runs at startup for every component.-architecture.storage:all.enable-v1-write-pathandall.enable-v1-read-pathwere deleted; replaced by-architecture.storage=v1|v2|v1-v2-dual.PYROSCOPE_V2_EXPERIMENTenv var: No longer read by the binary.-storage.backend=filesystem: Now the binary default.-enable-query-backend=true: Now defaults totrue./data-sharedvolume mount: The new default filesystem dir./data/v2/sharedfalls naturally under the existing/dataPVC mount.migration.queryBackend(flag no longer exists) andpersistence.sharedstanza (mount no longer used).Test plan
make helm/checkpasses (all 6 rendered variants validate with kubeconform)-architecture.storage=v1and-write-path=ingesterare set-architecture.storage=v2is set, no v1 flags-architecture.storage=v1-v2-dualand-write-path=combinedare setNote
Medium Risk
Changes runtime flags and storage/write-path behavior across all deployed components; misconfiguration could break ingestion/querying during upgrades despite being mostly Helm-level changes.
Overview
Updates the Pyroscope Helm chart to match v2.0 binary flag/behavior changes by switching components to the new
-architecture.storageflag and explicitly setting-write-path(includingingesterfor v1-only installs andcombinedfor dual-mode).Bumps chart
appVersion/rendered manifests from1.21.0tomain-171db75, removes deprecated v2 experiment/env and legacy shared data mount expectations, and adjusts documented values (eg.architecture.storage.migration.queryBackendFrom) to reflect the new migration semantics.Reviewed by Cursor Bugbot for commit 1243659. Bugbot is set up for automated code reviews on this repo. Configure here.