Fix missed v1 import path in pyroscope_test.go after module bump to v2#5077
Merged
simonswine merged 1 commit intomainfrom Apr 17, 2026
Merged
Fix missed v1 import path in pyroscope_test.go after module bump to v2#5077simonswine merged 1 commit intomainfrom
simonswine merged 1 commit intomainfrom
Conversation
pkg/pyroscope/pyroscope_test.go was still importing github.com/grafana/pyroscope/pkg/objstore/client (v1 path), causing golangci-lint to fail with "no export data" and go mod tidy to pull in github.com/grafana/pyroscope v1.21.0 as an unintended dependency.
aleks-p
approved these changes
Apr 17, 2026
marcsanmi
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/pyroscope/pyroscope_test.gowas still importinggithub.com/grafana/pyroscope/pkg/objstore/client(old v1 path) after the module was bumped togithub.com/grafana/pyroscope/v2in Bump Go module path to github.com/grafana/pyroscope/v2 #5073golangci-lint/gofmtto fail withno export data for "github.com/grafana/pyroscope/pkg/objstore/client"go mod tidyto pull ingithub.com/grafana/pyroscope v1.21.0as an unintended dependency, breaking thecheck/go/modstepFix
One-line change: update the import path to
github.com/grafana/pyroscope/v2/pkg/objstore/client.Test plan
Note
Low Risk
Low risk: a one-line test-only import path fix to align with the v2 module; no runtime logic changes.
Overview
Fixes
pkg/pyroscope/pyroscope_test.goto importobjstoreclientfromgithub.com/grafana/pyroscope/v2/...instead of the pre-v2 module path, preventing accidentalv1dependency pulls and related lint/go modfailures.Reviewed by Cursor Bugbot for commit c49423a. Bugbot is set up for automated code reviews on this repo. Configure here.