Skip to content

docs(v2): improve v1->v2 migration docs#5079

Merged
marcsanmi merged 1 commit intomainfrom
helm/improve-v1-v2-docs
Apr 20, 2026
Merged

docs(v2): improve v1->v2 migration docs#5079
marcsanmi merged 1 commit intomainfrom
helm/improve-v1-v2-docs

Conversation

@aleks-p
Copy link
Copy Markdown
Contributor

@aleks-p aleks-p commented Apr 17, 2026

helm upgrade --reuse-values will fail if the new chart has features that rely on values bundled with the chart (e.g. failed for me because of how #5067 and #4983 are set up).

Hence we switch to --reset-then-reuse-values which will overlay the installation values on top of the chart-bundled defaults.

Also updating the target chart version to 2.0.0 which is not yet released. We might want to backport this, but it is probably fine if we don't.


Note

Low Risk
Docs-only changes with no runtime impact, though pinning to an unreleased chart version could confuse users if they follow the commands verbatim.

Overview
Adjusts the v1→v2 storage migration guide to recommend helm upgrade with --reset-then-reuse-values (instead of --reuse-values) so chart-default values are retained while overlaying existing install values.

Pins the single-binary migration commands (Phase 1 dual ingest and Phase 3 cutover) to grafana/pyroscope --version 2.0.0, and removes the prerequisite callout about persistence being enabled.

Reviewed by Cursor Bugbot for commit 37f2e12. Bugbot is set up for automated code reviews on this repo. Configure here.

@aleks-p aleks-p requested review from a team as code owners April 17, 2026 20:07

You should see `v1: true` and `v2: false`. If you see `v2: true`, your installation is already using v2 or is mid-migration.

- **Persistence enabled** (`pyroscope.persistence.enabled=true`).
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this causes more confusion than anything. If a user tries to set it globally all components will request a volume, some will not get one and the installation will hang.

@marcsanmi marcsanmi merged commit 2cc2762 into main Apr 20, 2026
34 checks passed
@marcsanmi marcsanmi deleted the helm/improve-v1-v2-docs branch April 20, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants