docs(v2): improve v1->v2 migration docs#5079
Merged
Conversation
aleks-p
commented
Apr 17, 2026
|
|
||
| You should see `v1: true` and `v2: false`. If you see `v2: true`, your installation is already using v2 or is mid-migration. | ||
|
|
||
| - **Persistence enabled** (`pyroscope.persistence.enabled=true`). |
Contributor
Author
There was a problem hiding this comment.
I think this causes more confusion than anything. If a user tries to set it globally all components will request a volume, some will not get one and the installation will hang.
simonswine
approved these changes
Apr 17, 2026
marcsanmi
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helm upgrade --reuse-valueswill fail if the new chart has features that rely on values bundled with the chart (e.g. failed for me because of how #5067 and #4983 are set up).Hence we switch to
--reset-then-reuse-valueswhich will overlay the installation values on top of the chart-bundled defaults.Also updating the target chart version to 2.0.0 which is not yet released. We might want to backport this, but it is probably fine if we don't.
Note
Low Risk
Docs-only changes with no runtime impact, though pinning to an unreleased chart version could confuse users if they follow the commands verbatim.
Overview
Adjusts the v1→v2 storage migration guide to recommend
helm upgradewith--reset-then-reuse-values(instead of--reuse-values) so chart-default values are retained while overlaying existing install values.Pins the single-binary migration commands (Phase 1 dual ingest and Phase 3 cutover) to
grafana/pyroscope --version 2.0.0, and removes the prerequisite callout about persistence being enabled.Reviewed by Cursor Bugbot for commit 37f2e12. Bugbot is set up for automated code reviews on this repo. Configure here.