fix: ensure results.json is always included in trufflehog artifacts#94
Closed
isaiah-grafana wants to merge 9 commits intomainfrom
Closed
fix: ensure results.json is always included in trufflehog artifacts#94isaiah-grafana wants to merge 9 commits intomainfrom
isaiah-grafana wants to merge 9 commits intomainfrom
Conversation
- Changed to ./.github/workflows/reusable-trufflehog.yml - Will use the same branch as the org ruleset reference - Prepares for merging fixes into main branch
- Improved error handling for artifact preparation - Ensures results.json is always present in uploaded artifacts - Added clearer logging to show which files are copied - Creates empty results.json if scan produces no results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When downloading trufflehog scan artifacts, only the .txt file was included, not the .json file.
Solution
Changes
Result
Artifacts now always include both:
trufflehog_scan.txt(human-readable report)results.json(parseable JSON data)Even when no secrets are found, results.json will contain an empty array
[].