Skip to content

Support Node 18 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinwcyu merged 1 commit into from
Oct 23, 2023
Merged

Support Node 18 #245

kevinwcyu merged 1 commit into from
Oct 23, 2023

Conversation

@kevinwcyu
Copy link
Contributor

@kevinwcyu kevinwcyu commented Sep 14, 2023

  • Made the minimal amount of updates to dependencies to support Node 18
  • Tested with Node v18.17.1 locally with the following rm -rf node_modules && yarn && yarn lint && yarn test:ci && yarn build then tested it with a simple query

@kevinwcyu kevinwcyu requested a review from a team as a code owner September 14, 2023 19:40
@kevinwcyu kevinwcyu marked this pull request as draft September 14, 2023 20:00
@kevinwcyu kevinwcyu force-pushed the kevinwcyu/node-18 branch 3 times, most recently from c534c00 to e0e8ea0 Compare October 11, 2023 23:59
@kevinwcyu kevinwcyu marked this pull request as ready for review October 18, 2023 17:47
@kevinwcyu kevinwcyu merged commit 61994d2 into main Oct 23, 2023
@kevinwcyu kevinwcyu deleted the kevinwcyu/node-18 branch October 23, 2023 17:56
This was referenced Nov 10, 2023
Closed
Merged
@idastambuk idastambuk mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fridgepoet fridgepoet fridgepoet approved these changes

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinwcyu @fridgepoet