fix: sqlite3-binding.c error 'pread64' undeclared here#68
Merged
szkiba merged 1 commit intografana:masterfrom Jun 18, 2024
Merged
fix: sqlite3-binding.c error 'pread64' undeclared here#68szkiba merged 1 commit intografana:masterfrom
szkiba merged 1 commit intografana:masterfrom
Conversation
Contributor
Author
|
Hi @szkiba , It seems that some of the tests for 1.20.x failed, should I remove the update to 1.22 from this PR ? |
Contributor
Yes, since it is not related to sqlite bindings.... |
885b3ac to
c9f70af
Compare
c9f70af to
c27116c
Compare
Contributor
Author
Thanks for confirming. I just reverted it back to Go 1.21 |
szkiba
approved these changes
Jun 18, 2024
| module github.com/grafana/xk6-sql | ||
|
|
||
| go 1.21 | ||
| go 1.22 |
Contributor
There was a problem hiding this comment.
@jt-shippit Could you explain why this is necessary? One of the workflow tests does not run successfully because of this version change...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
The purpose of this PR is to resolve the following error while trying to build the Dockerfile supplied by this repo, the issue is related to the absence of certain functions (pread64, pwrite64, and off64_t) that are typically available in a glibc environment, but not in musl libc, which is used by Alpine Linux. So as a solution, I am proposing to use a distroless debian image which uses glibc and provides the necessary functions for building SQLite with the Go bindings.