This repository was archived by the owner on Apr 8, 2025. It is now read-only.
#163 added new Liquibase column parameters to gdsl #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you please also add the tests? |
Contributor
Author
|
I can, but its GDSL only change. |
Contributor
|
@puneetbehl @robertoschwald We do not have any tests for GDSL currently that I can see in the project (unless I'm missing something). We can certainly work on adding tests for GDSL if desired going forward, but I don't think we should delay this pull request for implementing those new tests. So, going to merge this as-is because these fields are supported as per Lliquibase documentation: https://docs.liquibase.com/concepts/advanced/column.html |
hayeskl
pushed a commit
to hayeskl/grails-database-migration
that referenced
this pull request
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#163
These fields are supported since Liquibase 3.1 / 3.4: