-
Notifications
You must be signed in to change notification settings - Fork 41
feat: Add playground to website #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy preview ready! 🌾
To edit notification comments on pull requests, go to your Netlify site settings. |
|
When I try the preview build, it compiles and runs fine, but any changes I make to the source are then ignored in future compiles |
This is not enough information to explain what you are doing (or doing wrong). I can say for a fact that I developed everything with |
|
When I click the Deploy Preview link to Netlify in this PR. (https://deploy-preview-316--grain-lang.netlify.app/playground) and press Compile and Run, it works fine, but any changes I make in the source code panel aren't reflected when I press Compile and Run a second time. |
There is a bug in the js-runner that @ospencer needs to look into that causes it to be stateful and break multiple runs. |
|
@marcusroberts I dropped Grain's js-runner completely and switched to using the new 1.x version of I tried a few simple examples but can you test your stuff again once the new deploy finishes? |
|
That fixed it! |
marcusroberts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me!
ospencer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent excellent work!
phated
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with @ospencer and I think we want this URL to be /try. These changes should do that
It's time for @spotandjake's wildest dreams to come true.
Casually ignore the committed 12mb grainc.bc.mjs - don't have a good way to automatically pull that into the repo.