Skip to content

Conversation

@phated
Copy link
Member

@phated phated commented Aug 22, 2022

It's time for @spotandjake's wildest dreams to come true.

Casually ignore the committed 12mb grainc.bc.mjs - don't have a good way to automatically pull that into the repo.

@phated phated requested a review from ospencer August 22, 2022 21:58
@netlify
Copy link

netlify bot commented Aug 22, 2022

Deploy preview ready! 🌾

Name Link
🔨 Latest commit a1e2803
🔍 Latest deploy log https://app.netlify.com/sites/grain-lang/deploys/6317aab70e64810009426e72
😎 Deploy Preview https://deploy-preview-316--grain-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marcusroberts
Copy link
Member

When I try the preview build, it compiles and runs fine, but any changes I make to the source are then ignored in future compiles

@phated
Copy link
Member Author

phated commented Aug 23, 2022

When I try the preview build, it compiles and runs fine, but any changes I make to the source are then ignored in future compiles

This is not enough information to explain what you are doing (or doing wrong). I can say for a fact that I developed everything with npm run start-playground and the rebuilds work perfectly.

@marcusroberts
Copy link
Member

marcusroberts commented Aug 23, 2022

When I click the Deploy Preview link to Netlify in this PR. (https://deploy-preview-316--grain-lang.netlify.app/playground) and press Compile and Run, it works fine, but any changes I make in the source code panel aren't reflected when I press Compile and Run a second time.

@phated
Copy link
Member Author

phated commented Aug 23, 2022

When I click the Deploy Preview link to Netlify in this PR. (https://deploy-preview-316--grain-lang.netlify.app/playground) and press Compile and Run, it works fine, but any changes I make in the source code panel aren't reflected when I press Compile and Run a second time.

There is a bug in the js-runner that @ospencer needs to look into that causes it to be stateful and break multiple runs.

@phated
Copy link
Member Author

phated commented Aug 24, 2022

@marcusroberts I dropped Grain's js-runner completely and switched to using the new 1.x version of @wasmer/wasi directly.

I tried a few simple examples but can you test your stuff again once the new deploy finishes?

@marcusroberts
Copy link
Member

That fixed it!

Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me!

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent excellent work!

Copy link
Member Author

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @ospencer and I think we want this URL to be /try. These changes should do that

@phated phated merged commit 0974deb into master Sep 7, 2022
@phated phated deleted the phated/playground branch September 7, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants