Merged
Conversation
Commit [`e11f365`] introduced build time regression - the dockerfile was modified to include two stages - one for build, another one for running. However, our compilation pipeline uses cross to build binaries, then copying it to final image. These dockerfile changes, combined with existing building pipeline, caused to build the same binary four times: two times for each supported platform. This commit reverts changes back to original Dockerfile build process, speeding up release pipeline (from ~1.5h to ~10 minutes). [`e11f365`]: grandinetech@e11f365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
e11f365introduced build time regression - the dockerfile was modified to include two stages - one for build, another one for running. However, our compilation pipeline uses cross to build binaries, then copying it to final image. These dockerfile changes, combined with existing building pipeline, caused to build the same binary four times: two times for each supported platform.This PR reverts changes back to original Dockerfile build process, speeding up release pipeline (from ~1.5h to ~10 minutes).