Improvements/implicit usings#582
Merged
KrzysztofPajak merged 3 commits intograndnode:mainfrom Mar 3, 2025
Merged
Conversation
Contributor
Author
|
@KrzysztofPajak Do you want me to add another commit that removes unused imports across the project that resulted from this PR? |
GuyPago
commented
Mar 1, 2025
b7ca9ee to
1d6f4d9
Compare
Member
|
There will probably be a lot of files, let's leave it as it is |
szjanikowski
pushed a commit
to NoesisVision/grandnode2
that referenced
this pull request
May 8, 2025
* Use implicit usings and remove manual global usings * Explicitly use `Grand.Infrastructure.StartupBase` * Slightly re-order `Grand.Common.props` --------- Co-authored-by: Guy Taggar <guypago@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #issueNumber
Type: improvements
Issue
Grand.Common.propsshould be as clean as possible. It manualy adds common namespaces as global, while .NET 6 provided a cleaner, built in way to do so.Solution
Add
UseGlobalUsingswhich behaves differently across different SDKs. e.g for Web environment:Grand.Web.GlobalUsings.g.cs
Breaking changes
Testing