BugFix: wrong equality comparision#114
Merged
grangier merged 1 commit intograngier:developfrom Jun 29, 2014
ankushshah89:develop
Merged
BugFix: wrong equality comparision#114grangier merged 1 commit intograngier:developfrom ankushshah89:develop
grangier merged 1 commit intograngier:developfrom
ankushshah89:develop
Conversation
Owner
|
thanks |
codelucas
added a commit
to codelucas/newspaper
that referenced
this pull request
Aug 6, 2014
Reference this fix in the repo of a library we used to be dependent on: grangier/python-goose#114
bylava995
pushed a commit
to bylava995/newspaper
that referenced
this pull request
Jul 31, 2025
Reference this fix in the repo of a library we used to be dependent on: grangier/python-goose#114
jyodroide
pushed a commit
to jyodroide/livebarcodescan
that referenced
this pull request
Oct 6, 2025
Reference this fix in the repo of a library we used to be dependent on: grangier/python-goose#114
MishaLaskine
added a commit
to MishaLaskine/G2P_CN_HCSI
that referenced
this pull request
Jan 19, 2026
Reference this fix in the repo of a library we used to be dependent on: grangier/python-goose#114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the equality comparison is wrong. Therefore goose was not able to extract text when the main text is in "td".
For eg: http://www.bangalore.philips.com/html/index.asp .
After this fix, it works fine.