Conversation
…e building and deployment to PyPI
…release tag - Removed `src/`, made new directory `c/` and copied in EAPS c/graphLib/ directory and contents. Also made sure to include EAPS LICENSE.txt and to preserve the README.md from Issue24 branch - Updated paths for headers from graphLib in planarity/cplanarity.pxd - Updated setup.py Extension sourcefiles with appropriate glob notation, as well as the include_dirs.
…re as of the 4.0.1 EAPS release tag.
…ribution: the include_dirs path included a trailing slash. Alternately, could include the following in the MANIFEST.in file: recursive-include planarity/c/graphLib *.c recursive-include planarity/c/graphLib *.h Also removed INSTALL.txt from MANIFEST.in file, since this file no longer exists (which referred to doc/source/install.rst, which doesn't seem to have ever existed anyhow??) Updated the README.md to include the vertex label to index mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #28
Updated
planarity/c/graphLib/, and reflect the EAPSgraphLibas of the 4.0.1 release tagmaster, as well as minor typographical changesREADME.md- addedplanarity.mapping(edgelist)to give the correspondence of vertex labels (specified inedgelist) and indices (shown in the result of the underlying call togp_DrawPlanar_RenderToString())planarity/__init__.py- bumped__version__so that it reflects the0.7.8version currently published to TestPyPIplanarity/cplanarity.pxd- updated paths to header files in this.pxddefinition fileplanarity/planarity.c- recompiled Cython extension usingcython3.2.4 to produce newplanarity.cto enable install in environments withoutcythondependencyMANIFEST.in- no longer need to explicitlyrecursive-includethe*.csource and*.hheader files associated with thegraphLib, since those should be included in the Source Distribution (and eventually Built Distributions) based on the configuration insetup.py(confirmed by inspecting the.tar.gzbuild artifact). RemovedincludeofINSTALL.txt, since this file no longer exists.setup.py- updatedsourcefilesandinclude_dirsto reflect new C sourcefile structurerequirements.txt- addedbuildandtwinebuild dependencies (further work to come in Splitrequirements.txtand manage versions usingdependabot#20 )Verification
clang)gcc15.2.0)cl)gcc14.2.0)