Skip to content

Updates to 3.11.0-SNAPSHOT and updates Gradle to 6.0.1#1

Merged
SirCipher merged 5 commits intomasterfrom
version-upgrade
Dec 5, 2019
Merged

Updates to 3.11.0-SNAPSHOT and updates Gradle to 6.0.1#1
SirCipher merged 5 commits intomasterfrom
version-upgrade

Conversation

@SirCipher
Copy link
Contributor

No description provided.

@SirCipher SirCipher requested a review from ajay-gov December 5, 2019 14:16
@SirCipher SirCipher changed the title Updates to 3.11.0-SNAPSHOT Updates to 3.11.0-SNAPSHOT and updates Gradle to 6.0.1 Dec 5, 2019
Copy link
Contributor

@ajay-gov ajay-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven { url 'http://packages.confluent.io/maven/' } in line 33 of the build.gradle file. Don't think we need it right?
Als can we go back to two space indents in the build.gradle file since we use that convention across other projects?

Looks good otherwise. Please merge with these fixes.

@SirCipher
Copy link
Contributor Author

SirCipher commented Dec 5, 2019

@ajay-gov I've removed the repository, changed the build.gradle formatting and also updated my IntelliJ's formatting settings for Groovy files to an indent of 2.

@SirCipher SirCipher closed this Dec 5, 2019
@SirCipher SirCipher reopened this Dec 5, 2019
@SirCipher SirCipher merged commit 6b37b96 into master Dec 5, 2019
@SirCipher SirCipher deleted the version-upgrade branch December 5, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants