Skip to content

Fix - casing typo for the SparkStackbar types config and datesetitem #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphieros merged 1 commit into from
Nov 4, 2024
Merged

Fix - casing typo for the SparkStackbar types config and datesetitem #101

graphieros merged 1 commit into from
Nov 4, 2024

Conversation

@cyrilf
Copy link
Contributor

@cyrilf cyrilf commented Nov 4, 2024

Based on the dominant choice in the code base, I renamed VueUiSparkStackBarConfig and VueUiSparkStackbarDatasetItem types to a lower Stackbar (lower b)

⚠️ This can be considered as a breaking change.

Linked to #98 and this comment

@graphieros graphieros merged commit 1f81c51 into graphieros:master Nov 4, 2024
@graphieros
Copy link
Owner

graphieros commented Nov 4, 2024

Merci @cyrilf :)

@cyrilf cyrilf deleted the fix-stackbar-typo branch November 5, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphieros graphieros graphieros approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyrilf @graphieros