Skip to content

Conversation

@ujaved931
Copy link
Contributor

@ujaved931 ujaved931 commented Nov 27, 2025

This pull request focuses on standardizing the naming conventions for CSS classes related to modal dialogs and drag handles across the codebase. The changes primarily replace generic or legacy class names with more specific, component-scoped names to enhance maintainability and prevent style conflicts.

CSS class name standardization and refactoring:

  • Updated modal dialog classes in BaseDraggableDialog.vue to use vue-ui-draggable-dialog-* prefixes instead of generic modal-* classes, including the container, header, title, and body elements. [1] [2] [3] [4] [5] [6]
  • Replaced the chart modal drag handle class in vue-ui-table.vue from modal-drag-handle to vue-ui-modal-drag-handle in both the template and CSS to match the new naming convention. [1] [2]

Defect BaseDraggableDialog - modal css class can conflict with UI libraries

@ujaved931 ujaved931 changed the title changed conflicting class names. Changed conflicting class names. Nov 27, 2025
@ujaved931
Copy link
Contributor Author

@graphieros ready for review 👍

Copy link
Owner

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!
Thank you very much:)

@graphieros graphieros merged commit 4ff2772 into graphieros:master Nov 27, 2025
@ujaved931 ujaved931 deleted the brForModalClassConflict branch November 27, 2025 13:32
@ujaved931
Copy link
Contributor Author

@graphieros you're welcome, I love the project and would like to contribute more in future, will keep an eye on the issues. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants