add errors for constraints on types #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enisdenjo
reviewed
May 31, 2023
Member
enisdenjo
left a comment
enisdenjo
left a comment
There was a problem hiding this comment.
This looks great, thank you!
I'd recommend updating the example in the readme to reflect that type constraints can be manipulated too.
enisdenjo
approved these changes
May 31, 2023
Contributor
Author
|
I added an example. In my case I am using crypt() on the password and only storing the hash, but I am just using the domain as a place to "store" the checks so I can test them like |
Member
|
Released in v1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to get errors from constraints on a domain. This worked for me.
Is adding the 2nd function the best way, and is it okay to change the exported function name?