Skip to content

Comments

Add CI check that links don't end in slash#2375

Merged
benjie merged 11 commits intographile:mainfrom
XanderG2:cli-test
Apr 7, 2025
Merged

Add CI check that links don't end in slash#2375
benjie merged 11 commits intographile:mainfrom
XanderG2:cli-test

Conversation

@XanderG2
Copy link
Contributor

@XanderG2 XanderG2 commented Feb 19, 2025

Description

adds a test to check if internal links end in slashes, as slashes at the end of links break navigation.

Performance impact

N/A

Security impact

N/A

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 4455d5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benjie benjie changed the title created link slash test Add CI check that links don't end in slash Mar 12, 2025
@benjie
Copy link
Member

benjie commented Mar 12, 2025

@jemgillam this looks good to me, but as you can see from the check being added to CI quite a lot of our links are already failing with it. I think you have work in progress to fix these, let's get that merged 👍

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent; thanks! 🙌

@github-project-automation github-project-automation bot moved this from 🌳 Triage to 🌱 In Progress in V5.0.0 Apr 7, 2025
@benjie benjie merged commit 7c6c377 into graphile:main Apr 7, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 🌱 In Progress to ✅ Done in V5.0.0 Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants