Conversation
🦋 Changeset detectedLatest commit: 6f95077 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benjie
force-pushed
the
fix-pubsub
branch
3 times, most recently
from
aaa9ebe to
d25029e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@danzho found a bug in PgSubscriber where an iterator result was being used as the value inside another iterator result. Seems the management in there was a mess... I've overhauled it with stronger types and better guarantees, now we only operate in iterator results and this should fix both this bug and any others sneakily hiding there.
TODO: test
Fixes PgSubscriber.next() returns {done:false, value:{done:true}} on release benjie/ouch#41