feat(pg): support domain constrained composite types

[jcgsville]

Addresses #600

Input types now support domains that constrain composite types instead of failing to generate the schema on startup.

I didn't add any testing as I was a bit unclear what the testing story is for a change like this. Happy to make any additions in this area with a quick point in the right direction.

[benjie]

Thanks @jcgsville; this is effectively a new type so we should add it to b.types:

graphile-engine/packages/postgraphile-core/__tests__/kitchen-sink-schema.sql

Line 237 in e863fd3

create table b.types (

Also add a mutation test for it in here:

https://github.com/graphile/graphile-engine/blob/v4/packages/postgraphile-core/__tests__/fixtures/mutations/types.graphql

And a query test here:

https://github.com/graphile/graphile-engine/blob/v4/packages/postgraphile-core/__tests__/fixtures/queries/types.graphql

These are all integration tests, effectively.

Changes to the above will require a lot of snapshot updates, you can run yarn --cwd packages/postgraphile-core jest -u to update them. You may need to fix a few other tests too - let the test results guide you.

Thanks!

[jcgsville]

Thanks for the guidance @benjie! I added some tests, which pass with Postgres 11, but it looks like Postgres 10 and earlier did not let you create a domain over a composite type, so the tests fail there. Is there a mechanism testing things only in certain versions?

[benjie]

@jcgsville Not a good one, but we did have to avoid PG10 tests running in PG9.6:

graphile-engine/packages/postgraphile-core/scripts/test

Lines 47 to 54 in 9dca5c8

	# Now run the tests
	if [ $SERVER_VERSION_NUM -ge 100000 ]; then
	jest --forceExit -i $@
	elif [ $SERVER_VERSION_NUM -ge 90500 ]; then
	jest --forceExit -i -t "^((?!pg10).)*$" $@
	else
	jest --forceExit -i -t "^((?!pg10|json-overflow).)*$" $@
	fi;

I'm not happy with our testing system in general (it's very legacy, clunky and slow), and am planning to overhaul it as part of the work I'm doing on V5.

[benjie]

@jcgsville Are you able to add a relevant workaround for PG11 as indicated above?

[benjie]

Need the tests to be skipped on unsupported PostgreSQL versions. (Added this status to help me track the issue.)

[benjie]

Merged v4 branch and then moved the test of this feature to the PG11 test suite.

[benjie]

Thanks for the fix 🙌

[jcgsville]

Sorry to have not gotten to the testing tweaks sooner. Thanks for ferrying it the rest of the way through 🙂

[benjie]

No worries 🙌