fix(types): fix parsing interval to support fractional seconds#678
Merged
Conversation
Member
Author
|
I've raised an issue with |
benjie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@keithlayne raised a PR #676 noting that fractional seconds were being truncated by PostGraphile. Upon further investigation I determined that the
postgres-intervalmodule was doing a lot more than we needed, so I've removed it and replaced it with a lean reimplementation of just the parse function (which should also have better performance, lower memory footprint, and smaller bundle size).Fixes #676
Performance impact
Ever so slight improvement.
Security impact
None known.