chore(deps): drop unused graphql-iso-date#712
Merged
benjie merged 1 commit intographile:v4from Feb 1, 2021
Merged
Conversation
benjie
approved these changes
Feb 1, 2021
Member
benjie
left a comment
There was a problem hiding this comment.
I'm not sure we've ever needed this 😕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord discussion
Description
The motivation behind this one-liner PR mostly boils down to cleaning up what appears to be a spurious warning when running
npm i --no-package-lockin projects consuming graphile-engine/PostGraphile.Apologies if I'm wrong in my hypothesis - I
acked through the repos for both graphile-engine as well as PostGraphile, looking for any instances ofrequire()orimportfor this module and found no actual usages (only insideyarn.lock).I happily defer to those smarter than me on this topic -- it would seem
graphql-iso-dateis going unused these days.The module itself appears to be unmaintained since late 2018; the README steers users towards graphql-scalars.
Also it sounds like PostGraphile may already have this functionality anyway?
Here's the previous PR that touched this.
Performance impact
I would imagine that running
npm installand possibly other things (e.g. app init) might be a tiny bit faster.Security impact
This dependency doesn't appear to be getting used anyway, so it should be immaterial, AFAICT.
Checklist
yarn lint:fixpasses.(Since this PR is a chore, the items under here seem irrelevant, but can expound more as desired)
yarn testpasses.RELEASE_NOTES.mdfile (if one exists).