Correct Docker localhost URLs in Docs#281
Merged
benjie merged 2 commits intographile:developfrom Jul 23, 2021
Merged
Conversation
As documented (and by default) local docker-compose endpoints are not HTTPS, they are HTTP. While certainly possible to run with HTTPS, as configured, they are HTTP listeners, and anyone visiting the exact URL will experience an error despite the HTTP URL working just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As documented (and by default) local docker-compose endpoints are not HTTPS, they are HTTP. While certainly possible to run with HTTPS, as configured, they are HTTP listeners, and anyone visiting the exact URL will experience an error despite the HTTP URL working just fine.
Performance impact
None - but it should help user experience for those who are following the docs and aren't too familiar with local hosting, docker, and HTTP/networking in general from being frustrated, is that performance?
Security impact
None
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).