Next.js 9.2#94
Merged
benjie merged 1 commit intographile:masterfrom Jan 20, 2020
singingwolfboy:next-9.2
Merged
Conversation
Member
|
That’s a shame, I’m a fan of CSS modules. |
Member
|
It looks like this has caused some duplicates in yarn.lock; please run |
Collaborator
Author
|
Done! As for CSS modules, we can use them if we drop LESS support in Next.js. But that means we would have to precompile the Antd theme somehow before calling Next, which feels messy and complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nextjs.org/blog/next-9-2
I wanted to take advantage of the new built-in CSS import support, but it seems we can't. Antd uses LESS for customizing the theme, and in order to make Next.js work with LESS, we need the
@zeit/next-lesspackage, which needs the@zeit/next-csspackage, which disables the new built-in CSS import support (for backwards compatibility).We still get improved code-splitting, though!