pgcrypto not necessary in PostgreSQL 13+?

[noinkling]

Correct me if I'm wrong, but pgcrypto only appears to be installed in order to use gen_random_uuid(). That function is available without the extension in Postgres 13+. Is it feasible to make the installation of pgcrypto conditional on version so it can be avoided if unnecessary?

[benjie]

Seems like a reasonable suggestion; here's the relevant line if you fancy sending a PR:

worker/src/migrate.ts

Line 10 in e3176ea

create extension if not exists pgcrypto with schema public;

[benjie]

To be honest, we could just remove that line and state in the README that if you want to use < PG13 you'll need to install the pgcrypto extension 🤷‍♂️

[noinkling]

I won't offer any input on that decision since it wouldn't affect me personally, other than to say it sounds like a better idea in the long term.

Either way, currently gen_random_uuid() calls are qualified with the public schema, whereas the built-in version is on pg_catalog. Is it OK to unqualify it and just implicitly rely on the search_path in older versions?

Alternatively I guess you could create a proxy function in the graphile-worker schema that simply delegates to the appropriate one.

[benjie]

Removing the qualification sounds acceptable.