Phase 1: #1219 row-boolean WHERE audit + TCK-linked tests#1223
Open
lmeyerov wants to merge 3 commits intoissue-1031-grammar-mixed-where-pattern-exprfrom
Open
Phase 1: #1219 row-boolean WHERE audit + TCK-linked tests#1223lmeyerov wants to merge 3 commits intoissue-1031-grammar-mixed-where-pattern-exprfrom
lmeyerov wants to merge 3 commits intoissue-1031-grammar-mixed-where-pattern-exprfrom
Conversation
This was referenced Apr 26, 2026
lmeyerov
commented
Apr 26, 2026
| comparison_val = comparison_val.tz_localize(None) | ||
| return prepared_s, comparison_val | ||
|
|
||
| def _safe_scalar_compare( |
Contributor
Author
There was a problem hiding this comment.
needs careful exhaustive testing across platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #1219 stack: test/audit hardening only (no behavior expansion).
Adds a focused row-boolean WHERE matrix for:
Why
#1217(Earley parser) broadens accepted row-boolean shapes. This PR captures current support boundaries with explicit positive/negative coverage and TCK-linked IDs where applicable, so Phase 2 can expand behavior against a fixed audit baseline.Scope
graphistry/tests/compute/gfql/cypher/test_lowering.pytest_issue_1219_row_boolean_audit_*matrix testsValidation
Ran:
./bin/pytest.sh graphistry/tests/compute/gfql/cypher/test_lowering.py -k "issue_1219_row_boolean_audit" -qResult: 9 passed.
Stack
issue-1031-grammar-mixed-where-pattern-expr)Refs #1219