fix(cypher): admit free-form carried-property bridge refs (#1275)#1287
Merged
fix(cypher): admit free-form carried-property bridge refs (#1275)#1287
Conversation
This was referenced May 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WHERE c.id = x.id,RETURN x.id)multi_alias_carriesinto free-form lowering +ReentryPlanmetadata and remove the prior carried-property failfastWhereClausepaths (expr_tree=None) so bridge predicates are rewritten instead of leaking unresolved aliasesCloses #1275.
Validation
python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "intermediate_reentry_match_with_carried_property_bridge_where"python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "intermediate_reentry_match_with_carried_property_bridge_where or simple_freeform_intermediate_reentry_match or freeform_intermediate_reentry_match_with_multi_carried_aliases or freeform_intermediate_reentry_match_with_empty_prefix or freeform_intermediate_reentry_match_on_multi_row_prefix or with_match_reentry_carried_scalar_where or with_match_reentry_where_or_on_carried_and_trailing_alias_props or with_match_reentry_where_xor_on_carried_and_trailing_alias_props or issue_1026_multi_alias_with_optional_match_carries_secondary_property or multi_alias_with_stage_scalar_projection_executes"python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "tck- or with-where3-3 or issue_1273 or 1275"uv run ruff check graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.pyGPU note
plans/issue-1275/plan.mdand hit remote environment/path provisioning issues.