Skip to content

chore(gfql): disambiguate reentry compile-time module naming#1335

Merged
lmeyerov merged 1 commit intomasterfrom
chore-1333-reentry-module-naming
May 7, 2026
Merged

chore(gfql): disambiguate reentry compile-time module naming#1335
lmeyerov merged 1 commit intomasterfrom
chore-1333-reentry-module-naming

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented May 7, 2026

Summary

Closes #1333 with a low-risk naming cleanup in Cypher reentry internals:

  • move compile-time bounded-reentry helper ownership from reentry/runtime.py to reentry/compiletime.py
  • keep reentry/runtime.py as a compatibility re-export shim
  • switch lowering call sites/comments/tests to the compile-time module naming

No semantic behavior change intended.

Why

execution.py now clearly represents runtime dataframe behavior, while the former runtime.py was compile-time query rewrite/orchestration logic. This rename reduces maintainer confusion.

Validation

  • python -m pytest -q graphistry/tests/compute/gfql/test_ir_type_propagation.py::TestSeamWith1303LoweringSplit graphistry/tests/compute/gfql/cypher/test_lowering_s3_split_guard.py
  • ./bin/ruff.sh graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql/cypher/reentry/runtime.py graphistry/compute/gfql/cypher/reentry/compiletime.py graphistry/compute/gfql/cypher/reentry/execution.py graphistry/tests/compute/gfql/test_ir_type_propagation.py

Notes

  • Added Development changelog entry.
  • Review-skill artifacts: plans/issue-1333-reentry-module-naming/review/final-report.md (local plan memory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(cypher): disambiguate compile-time reentry module naming vs runtime execution module

1 participant