Conversation
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1343 by routing multiplicity-sensitive Cypher aggregates on relationship-pattern MATCH queries through bindings-row execution so row multiplicity is preserved before aggregation.
What changed
rows(binding_ops=...)) so repeated relationship rows survive togroup_by.repeated MATCH rowsaggregate guard to non-bindings paths.count(*),count(alias),sum(1),avg(edge_prop)OPTIONAL MATCH ... WITH p, collect(uni.name)OPTIONAL MATCH ... WITH p, collect(CASE ...)WITH a, count/sum/avg(...)Development.CI guard update
bin/ci_cypher_surface_guard_baseline.jsonto match intentionallowering.pygrowth from this feature and follow-up safety constraints.python bin/ci_cypher_surface_guard.py(pass).Validation
./bin/ruff.sh graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.pypython -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.pypython -m pytest -q tests/gfql/ref/test_df_executor_core.py -k "missing_alias_raises or missing_where_column_raises_during_input_build or where_missing_column_after_prior_call_still_rejected"python bin/ci_cypher_surface_guard.pyNotes
RETURN a, count(*)) remains on the legacy representation path and is not expanded in this change.