Skip to content

Fix #1342: preserve WITH ORDER BY/LIMIT across MATCH re-entry#1350

Merged
lmeyerov merged 1 commit intomasterfrom
issue-1342-with-orderby-limit-reentry
May 8, 2026
Merged

Fix #1342: preserve WITH ORDER BY/LIMIT across MATCH re-entry#1350
lmeyerov merged 1 commit intomasterfrom
issue-1342-with-orderby-limit-reentry

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented May 7, 2026

Summary

  • relax bounded re-entry ORDER BY safety gate to admit literal LIMIT (with no SKIP) instead of only LIMIT 1
  • keep fail-fast for unbounded or SKIP-based ORDER BY prefixes when trailing query has no ORDER BY
  • add regression coverage for single-column, multi-column, and DESC ORDER BY + LIMIT through trailing MATCH, plus cuDF parity
  • add changelog entry under Development

Issue

Closes #1342

Validation

  • python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "preserves_orderby or rejects_with_match_reentry_unbounded_or_skip_order_shapes or rejects_reentry_with_parameterized_limit_and_order"
  • python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "with_match_reentry and not cudf"
  • python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "executes_with_match_reentry_limit_shape or preserves_orderby or unbounded_or_skip or rejects_reentry_with_parameterized_limit_and_order"
  • uv run ruff check graphistry/compute/gfql/cypher/reentry/carry.py graphistry/compute/gfql/cypher/reentry/compiletime.py graphistry/tests/compute/gfql/cypher/test_lowering.py

Review skill artifacts

  • plans/issue-1342/review-pr-local/final-report.md

@lmeyerov lmeyerov force-pushed the issue-1342-with-orderby-limit-reentry branch from fe5df51 to 7d41625 Compare May 8, 2026 00:40
@lmeyerov lmeyerov force-pushed the issue-1342-with-orderby-limit-reentry branch from 7d41625 to 60f1bb9 Compare May 8, 2026 00:59
@lmeyerov lmeyerov merged commit 0526f20 into master May 8, 2026
137 checks passed
@lmeyerov lmeyerov deleted the issue-1342-with-orderby-limit-reentry branch May 8, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cypher WITH ORDER BY / LIMIT not preserved across MATCH re-entry for multi-row results

1 participant