Fix #1342: preserve WITH ORDER BY/LIMIT across MATCH re-entry#1350
Merged
Fix #1342: preserve WITH ORDER BY/LIMIT across MATCH re-entry#1350
Conversation
fe5df51 to
7d41625
Compare
7d41625 to
60f1bb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIMIT(with noSKIP) instead of onlyLIMIT 1Issue
Closes #1342
Validation
python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "preserves_orderby or rejects_with_match_reentry_unbounded_or_skip_order_shapes or rejects_reentry_with_parameterized_limit_and_order"python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "with_match_reentry and not cudf"python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "executes_with_match_reentry_limit_shape or preserves_orderby or unbounded_or_skip or rejects_reentry_with_parameterized_limit_and_order"uv run ruff check graphistry/compute/gfql/cypher/reentry/carry.py graphistry/compute/gfql/cypher/reentry/compiletime.py graphistry/tests/compute/gfql/cypher/test_lowering.pyReview skill artifacts
plans/issue-1342/review-pr-local/final-report.md