fix(gfql/row): close #1373 cuDF host bridge + row test follow-ups#1404
Open
fix(gfql/row): close #1373 cuDF host bridge + row test follow-ups#1404
Conversation
This was referenced May 9, 2026
88bb7e0 to
871732b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the remaining Worker C follow-ups for #1373 by hardening the ORDER BY stringified-list path and continuing row-test placement cleanup.
What changed
graphistry/compute/gfql/row/pipeline.pyfor parsed stringified-list sort keys beforeassign(...)when a pandas Series is present.parse_stringified_list_series()docstring (graphistry/compute/gfql/row/ordering.py).graphistry/tests/compute/gfql/row/test_ordering.pyfor stringified-list subscript ORDER BY expressions.graphistry/tests/compute/gfql/cypher/test_lowering.pywhile keeping thin cypher smoke coverage.Why
Validation
python -m pytest -q graphistry/tests/compute/gfql/row/test_ordering.pypython -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "stringified_list_column_uses_list_orderability or order_by_list_literal_and_subscript_expression or order_by_stringified_list_subscript_expression"python -m pytest -q graphistry/tests/compute/gfql/test_row_pipeline_ops.py -k "order_by_stringified_list_column_on_cudf_when_available or order_by_stringified_list_column_uses_list_orderability"uv run ruff check graphistry/compute/gfql/row/pipeline.py graphistry/compute/gfql/row/ordering.py graphistry/tests/compute/gfql/row/test_ordering.py graphistry/tests/compute/gfql/cypher/test_lowering.py./bin/mypy.sh graphistry/compute/gfql/row/pipeline.py graphistry/compute/gfql/row/ordering.pyLinks