fix(cypher): disambiguate IC4 HAS_TAG endpoints#1502
Merged
Conversation
d2770e0 to
4c567c5
Compare
4c567c5 to
e1d1022
Compare
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1496.
Summary
HAS_<Label>destination bindings when graph node ids collide across labels and the impliedlabel__<Label>column exists.PostandTagrows.CHANGELOG.md.Why
pyg-bench#4showed direct-Cypher IC4 executing but returning the wrong tag set after the CASE blocker was fixed. The in-repo IC4 tests used globally unique ids, while the benchmark graph can have cross-label numeric id collisions. In that shape,-[:HAS_TAG]->(tag)is unlabeled, and the connected row-binding join could bind the collidingPostrow astagbeforesum(valid)/sum(inValid)and the post-aggregationWHERE.Validation
python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1496_ic4_unlabeled_has_tag_destination_disambiguates_colliding_ids[pandas]python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'issue_1496 or ic4 or 1413'python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k '(multi_alias or issue_1496 or issue_1413 or binding_rows or rows) and not cudf'./bin/ruff.sh graphistry/compute/gfql/row/pipeline.py graphistry/tests/compute/gfql/cypher/test_lowering.py./bin/typecheck.sh graphistry/compute/gfql/row/pipeline.pygit diff --checkNote: the local broader slice without
and not cudfhit unrelatedcudaErrorNoDevicefailures because this workstation imports cuDF but has no CUDA device. cuDF validation was done ondgx-spark.pyg-bench follow-up
After this lands, rerun
graphistry/pyg-bench#4IC4/new-topics direct-Cypher conformance against a prepared pyg-bench checkout with the SF0.1 fixture:If SF0.1 reports
ok, then consider the SF1/no-warmup rerun only if coordinator wants a scale confirmation; prior notes say SF1 can OOM on the shared DGX box.