infra: replace flake8 with ruff for linting (closes #466)#924
Merged
lmeyerov merged 3 commits intographistry:masterfrom Feb 28, 2026
Merged
infra: replace flake8 with ruff for linting (closes #466)#924lmeyerov merged 3 commits intographistry:masterfrom
lmeyerov merged 3 commits intographistry:masterfrom
Conversation
- Add pyproject.toml with [tool.ruff] config translating all flake8 rules (E/W, F, C90) and ignore list from bin/flake8.sh - Add bin/ruff.sh runner with quick syntax + full lint passes - Update bin/lint.sh to resolve ruff (uvx > bare > python -m) - Deprecate bin/flake8.sh as wrapper delegating to ruff.sh - Replace flake8 with ruff>=0.8.0 in setup.py test extras - Clean stale # noqa comments for W503/W504/E126 (not applicable in ruff) - Update CHANGELOG.md, DEVELOP.md, and docs references Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lmeyerov
requested changes
Feb 25, 2026
Contributor
There was a problem hiding this comment.
Thank you @roli-lpci !
I approved a ci run
Two things popped in AI review:
- flake8 references remain in docs/internal guidance (e.g., ai/README.md, ai/prompts/LINT_TYPES_CHECK.md) and the wrapper bin/flake8.sh is still present (even if
deprecated)
- bin/lint.sh prefers uvx ruff, which may use an unpinned Ruff version if uvx is available. If reproducibility matters, consider forcing python -m ruff from the venv or pinning
in CI.
-
Can you finish updating the references?
-
Unsure on the second comment. We intentionally keep lint/type checking unpinned for helping catch latest issues, though I do think it's supposed to be env conrollled.
- ai/README.md: update WITH_LINT description from flake8 to ruff - ai/prompts/LINT_TYPES_CHECK.md: replace all flake8 references with ruff - bin/ruff.sh: remove stale flake8 comment - bin/flake8.sh: delete deprecated wrapper script Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…oml comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
ci passed in #925 , merging, thanks! |
lmeyerov
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff.toml/pyproject.tomlruff checkinstead offlake8Test plan
ruff check .passes with no new violations