Fix XSS via unsanitized user input in Absolute Time Range validation tooltips#2910
Merged
Fix XSS via unsanitized user input in Absolute Time Range validation tooltips#2910
Conversation
…on tooltips Co-authored-by: deniszh <1227222+deniszh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [GH-2746] Check and fix issue with graphite-web
Fix XSS via unsanitized user input in Absolute Time Range validation tooltips
Mar 17, 2026
deniszh
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtJS renders form field validation errors as HTML in QuickTip tooltips. The
DateFieldandTimeFielddefaults embed the raw user value via{0}ininvalidText(e.g."{0} is not a valid date"), which flows directly intoinnerHTMLon hover — allowing arbitrary script execution via inputs like<img src=1 onerror=alert()>.Change
Override
invalidTexton all four fields inselectAbsoluteTime()with static strings containing no user-input placeholder:Same applied to
startTimeField,endDateField, andendTimeField.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.