Skip to content

Fix single quotes in dashboard targets being replaced with double quotes#2911

Merged
deniszh merged 2 commits intomasterfrom
copilot/fix-cache-bug-2885
Mar 17, 2026
Merged

Fix single quotes in dashboard targets being replaced with double quotes#2911
deniszh merged 2 commits intomasterfrom
copilot/fix-cache-bug-2885

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 17, 2026

In the dashboard, all single quotes in graph target expressions were silently converted to double quotes via .replace(/'/g, '"') in syncGraphs. This corrupts expressions that legitimately use single quotes inside double-quoted string arguments — most notably applyByNode:

# User enters:
applyByNode(metric*,1,"function('here')")

# Dashboard silently transforms to (malformed):
applyByNode(metric*,1,"function("here")")

The malformed target causes a pyparsing.exceptions.ParseException when the render API tries to parse it.

Changes

  • webapp/content/js/dashboard.js: Remove .replace(/'/g, '"') from the syncGraphs function — the graphite grammar uses pyparsing's quotedString which supports both single- and double-quoted string literals natively, so no normalization is needed.

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

@deniszh deniszh marked this pull request as ready for review March 17, 2026 22:38
…s function

Co-authored-by: deniszh <1227222+deniszh@users.noreply.github.com>
Copilot AI changed the title [WIP] [2885] Fix cache issue affecting data display Fix single quotes in dashboard targets being replaced with double quotes Mar 17, 2026
Copilot AI requested a review from deniszh March 17, 2026 22:40
@deniszh deniszh merged commit ffaa3d2 into master Mar 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants