move id extraction into I3FeatureExtractor #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortenHolmRep
approved these changes
May 20, 2023
Collaborator
MortenHolmRep
left a comment
MortenHolmRep
left a comment
There was a problem hiding this comment.
Sounds like a reasonable change and LGTM :)
RasmusOrsoe
added a commit
to RasmusOrsoe/graphnet
that referenced
this pull request
Oct 25, 2023
…nd-dom_id move id extraction into I3FeatureExtractor
carlosm-silva
pushed a commit
to carlosm-silva/graphnet
that referenced
this pull request
Jul 7, 2025
…nd-dom_id move id extraction into I3FeatureExtractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the extraction of "
string", "pmt_number", "dom_number" and "dom_type" out ofI3FeatureExtractorIceCubeUpgradeand intoI3FeatureExtractorIceCube86. Note thatI3FeatureExtractorIceCubeUpgradewill still extract these variables due to inheritance.These variables are available on regular IceCube simulation and not inherent to Upgrade. By moving them, we make sure other datasets will have it available too.