Skip to content

Comments

Refactor standard model#707

Merged
RasmusOrsoe merged 6 commits intographnet-team:mainfrom
RasmusOrsoe:refactor-standard-model
May 17, 2024
Merged

Refactor standard model#707
RasmusOrsoe merged 6 commits intographnet-team:mainfrom
RasmusOrsoe:refactor-standard-model

Conversation

@RasmusOrsoe
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe commented May 3, 2024

Refactors StandardModel such that the easy syntax (.fit, .predict_as_dataframe, etc) is stored in a seperate class EasySyntax, allowing different Model s to use it without the restrictions of StandardModel. Refactor is done according to the discussion in #527

Copy link
Collaborator

@Aske-Rosted Aske-Rosted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RasmusOrsoe RasmusOrsoe merged commit f5167f3 into graphnet-team:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants