Fixing the get_primaries function of I3Extractor#818
Merged
sevmag merged 5 commits intographnet-team:mainfrom Aug 13, 2025
Merged
Fixing the get_primaries function of I3Extractor#818sevmag merged 5 commits intographnet-team:mainfrom
sevmag merged 5 commits intographnet-team:mainfrom
Conversation
Aske-Rosted
reviewed
Aug 13, 2025
| ) | ||
| ] | ||
|
|
||
| # This is not expected to happen |
Collaborator
There was a problem hiding this comment.
Is this still true, do all NuGen events have a In-Ice-neutrino generated by the daughter particles?
Collaborator
Author
There was a problem hiding this comment.
The message was wrong. It should say in-ice particle. Does not necessarily have to be a neutrino
Aske-Rosted
approved these changes
Aug 13, 2025
Collaborator
Aske-Rosted
left a comment
Aske-Rosted
left a comment
There was a problem hiding this comment.
Just a single comment otherwise looks good.
This was referenced Aug 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem in #817.
As a fix to Problem 1 explained in #817, I introduce a function
find_in_ice_daughtersthat recursively looks for in-ice particles in the subtree of the primary neutrino.This solution makes sure that ...
primarieslist of particles where one of the particles might be a daughter of another (as explained in Unexpected behaviour in I3Extractor.get_primaries #817)As a fix to Problem 2 explained in #817, I introduce the argument
highest_energy_primarythat allows to return all primaries found instead of only the highest-energy one in the case of a NuGen file