Skip to content

Conversation

@RembrandtK
Copy link
Contributor

Rebase of #1243 onto main.

Pending:

Rebasing required changes to pnpm.yaml but otherwise changes nothing except commit metadata:

diff \
  <(git show ec0c9841 -- ':!pnpm-lock.yaml') \
  <(git show 8c08f3a6 -- ':!pnpm-lock.yaml')

Where the commit hashes (at time of writing) of only commits on respective branches relative to main:

git log --oneline main..issuance-baseline-2
git log --oneline main..issuance-baseline-4

Baseline issuance package and integrates issuance allocation/eligibility patterns into RewardsManager. This is an upgrade to RewardsManager but does not yet introduce the Rewards Eligibility Oracle or Issuance Allocator. Provided those are not set yet on RewardsManager this does not change the behaviour of RewardsManager.

RewardsManager Integration (packages/contracts)

  • Added eligibility oracle support with setRewardsEligibilityOracle() and rewardsEligibilityOracle storage
  • Added issuance allocator support with setIssuanceAllocator() and issuanceAllocator storage
  • Integration validated through comprehensive test suites covering configuration, calculations, and distribution patterns

New Package: packages/issuance

  • Core interfaces for Rewards Eligibility Oracle (IRewardsEligibility) and Issuance Allocator (IIssuanceAllocationDistribution, IIssuanceTarget)
  • Shared base contracts (BaseUpgradeable) and common utilities (IPausableControl)
  • Test infrastructure and fixtures for downstream implementation PRs

Cherry-picked from ec0c984 (issuance-baseline-2/3)
Rebased onto main with regenerated lockfile
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​nomicfoundation/​hardhat-toolbox@​5.0.0981007679100
Added@​openzeppelin/​hardhat-upgrades@​3.9.19910010086100

View full report

@RembrandtK RembrandtK mentioned this pull request Nov 17, 2025
@openzeppelin-code
Copy link

Issuance baseline (rebased)

Generated at commit: 8c08f3a63b4f0f766501b8dead917729fed5f82e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
5
0
14
38
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.67%. Comparing base (380f6ad) to head (8c08f3a).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ages/issuance/contracts/common/BaseUpgradeable.sol 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   84.05%   83.67%   -0.38%     
==========================================
  Files          42       43       +1     
  Lines        2070     2120      +50     
  Branches      615      633      +18     
==========================================
+ Hits         1740     1774      +34     
- Misses        330      346      +16     
Flag Coverage Δ
unittests 83.67% <58.82%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants