fix firehose eth CallHandler triggering on reverted calls#3762
Merged
Conversation
leoyvens
approved these changes
Jul 22, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firehose exposes calls that are "failed" or "reverted". current behavior is to only filter out the transactions that are completely reverted (from the status in the Receipt).
This fixes POI inconsistencies seen in QmPDp878JK2RcvXNhWX1UQHYbhF8iEcWPTdnP9bJvy6L6P (and hopefully QmUrfWjK7rdXzbr3q6D2DVDapCw4yWBU88qjrNvZUewoNy too)
Additional notes
tracesis done on the existence of theerrorfield. This field does not exist in firehose calls, so we must use another firehose-specific field.state_revertedfield to correctly skip calls that had no effect on the chain.We need to be able to compare existing POIs from RPCs with POIs from firehose to ensure that the transition is successful, so this PR will make firehose mimic the RPC behavior (and not fix #3701 for the moment).