graphman: validate deployment before activating #5784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyasmohd
force-pushed
the
shiyasmohd/disallow-activating-for-copying-deployment
branch
from
b60ce63 to
ce430bc
Compare
lutter
requested changes
Feb 11, 2025
| "copying is queued but has not started or no copy operation for {} exists", | ||
| deployment.id.0 | ||
| ); | ||
| return Ok(()); |
Collaborator
There was a problem hiding this comment.
In that case, don't we want the activate to actually do something?
| store.activate(&deployment)?; | ||
| println!("activated copy {}", deployment); | ||
| } else { | ||
| println!("copying is not finished yet"); |
Collaborator
There was a problem hiding this comment.
Could you add some more information to the error, like
the deployment sgdNNN is being copied from sgdNNN and can therefore not be activated yet
|
This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4460