Skip to content

display current node when reassigning subgraph #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shiyasmohd merged 1 commit into from
Apr 17, 2025
Merged

display current node when reassigning subgraph #5910

shiyasmohd merged 1 commit into from
Apr 17, 2025

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Mar 25, 2025

When reassigning subgraphs, the current assigned node is not displayed. This PR solves this issue.

@fordN fordN requested a review from isum April 15, 2025 15:46
incrypto32
incrypto32 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@incrypto32 incrypto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You might have to rebase and use signed commits to merge

@incrypto32
Copy link
Member

incrypto32 commented Apr 16, 2025

@isum i thought it was assigned to me🤦‍♂️ didn't look before reviewing😅.

@incrypto32
Copy link
Member

incrypto32 commented Apr 17, 2025

@shiyasmohd looks like the rebase went, wrong the commit history is not right now

@shiyasmohd shiyasmohd force-pushed the shiyasmohd/print-curr-node-on-reassign branch from f2106d6 to adfcdd7 Compare April 17, 2025 07:48
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/print-curr-node-on-reassign branch from adfcdd7 to a9d89ff Compare April 17, 2025 07:50
@shiyasmohd
Copy link
Contributor Author

shiyasmohd commented Apr 17, 2025 •
edited
Loading

@incrypto32 Its fixed now.

@shiyasmohd shiyasmohd merged commit be6c940 into master Apr 17, 2025
6 checks passed
@jhjhjh94
Copy link

jhjhjh94 commented May 15, 2025 •
edited
Loading

still not showing on graphnode 0.38.0

graphman reassign <subgraph> indexnode
Reassigning deployment <subgraph>[1400]
This is the only deployment assigned to 'indexnode'. Please make sure that the node ID is spelled correctly.

previously on 0.36.1

graphman reassign <subgraph> indexnode
Reassigning deployment <subgraph>[1400] (was index_node_0) <---
This is the only deployment assigned to 'indexnode'. Please make sure that the node ID is spelled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@incrypto32 incrypto32 incrypto32 approved these changes

@isum isum Awaiting requested review from isum

Assignees

@shiyasmohd shiyasmohd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shiyasmohd @incrypto32 @jhjhjh94