node: 'graphman copy status': Use bigger columns for next and target #5956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the column widths in the "graphman copy status" output to accommodate larger vid values for huge subgraphs. Key changes include increasing the column widths for "next" and "target" from 8 to 10 characters, and updating the corresponding table row formatting.
Comments suppressed due to low confidence (1)
node/src/manager/commands/copy.rs:342
- The separator line width remains 74 characters, which may no longer match the overall table width after increasing the 'next' and 'target' columns to 10 characters each. Consider updating the separator length to 78 characters to align with the modified table layout.
println!("{:-<74}", "-");
lutter
force-pushed
the
lutter/copy-status
branch
from
377eb4b to
805c4a5
Compare
incrypto32
approved these changes
Apr 28, 2025
lutter
force-pushed
the
lutter/copy-status
branch
from
805c4a5 to
08c4130
Compare
Collaborator
Author
|
This was merged with commit 08c4130 - I just screwed up my git commands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vids for huge subgraphs can go into the billions; this change makes the columns big enough for that