Skip to content

chain: Do not use the block cache for is_on_main_chain #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
incrypto32 merged 1 commit into from
Apr 23, 2026
+6 −12
Merged

chain: Do not use the block cache for is_on_main_chain #6537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions chain/ethereum/src/chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,12 @@ impl TriggersAdapterTrait<Chain> for TriggersAdapter {
}

async fn is_on_main_chain(&self, ptr: BlockPtr) -> Result<bool, Error> {
// It is tempting to use the block cache here; but that can go wrong
// when graph-node gets shut down and some of its nonfinal blocks
// then are reorged; when graph-node gets started again when those
// block numbers have become final, it might consider a reorged
// block as canonical; allowing the use of the block cache here
// would require us to also track the finality of blocks.
match &*self.chain_client {
ChainClient::Firehose(endpoints) => {
let endpoint = endpoints.endpoint().await?;
Expand All @@ -1088,18 +1094,6 @@ impl TriggersAdapterTrait<Chain> for TriggersAdapter {
Ok(block.hash() == ptr.hash)
}
ChainClient::Rpc(adapter) => {
let cached = self
.chain_store
.cheap_clone()
.block_ptrs_by_numbers(vec![ptr.number])
.await
.unwrap_or_default();
if let Some(ptrs) = cached.get(&ptr.number)
&& ptrs.len() == 1
{
return Ok(ptrs[0].hash == ptr.hash);
}

let adapter = adapter
.cheapest()
.await
Expand Down
Loading