Nik/support new api #147
Merged
Nik/support new api #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1431b0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikgraf
force-pushed
the
nik/support-new-api
branch
from
8c1afe3 to
1431b0c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new API environment by introducing a TESTNET_V2 network option. The change enables the SDK to work with the new testnet contracts and API endpoint while maintaining backward compatibility with the existing TESTNET and MAINNET networks.
Changes:
- Added
TESTNET_V2as a new network option throughout the codebase - Introduced a centralized
Networktype andgetApiOrigin()function to replace inline conditionals - Updated documentation to indicate that certain examples are outdated when working with new contracts
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/graph/constants.ts | Added TESTNET_V2_API_ORIGIN constant, Network type, and getApiOrigin() helper function |
| src/graph/index.ts | Exported new TESTNET_V2_API_ORIGIN, Network type, and getApiOrigin function |
| src/types.ts | Updated CreateImageParams network property to include TESTNET_V2 |
| src/ipfs.ts | Replaced inline network conditionals with Network type and getApiOrigin() function |
| src/ipfs.test.ts | Updated test to use TESTNET_V2 network |
| src/graph/create-space.ts | Replaced inline network conditional with getApiOrigin() function |
| src/graph/create-image.ts | Added TESTNET_V2 to alternative gateway condition |
| src/encoding.ts | Replaced inline network conditional with getApiOrigin() function |
| README.md | Added comments indicating outdated examples when working with new contracts |
| .changeset/eighty-trams-poke.md | Changelog entry for the new network option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.