-
Notifications
You must be signed in to change notification settings - Fork 8
fix: implement encryption based on XMTP but using noble #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good find. and who doesn't love one less dep
Code looks good from my perspective. One thing I would do to be 100% certain is
This way we can be very certain that this is correct. Do you think it's worth it? |
The problem is xmtp-js was breaking our tests because of the weird issue on webcrypto.subtle. Their serialization/deserialization after encryption is also different than ours so it would take a bit of wrangling. So I think it would be a good idea but considering the tradeoffs I would prefer not to add that test for now. Once we're closer to a release version we can work with the Foundation to set up an external security review. Does that sound reasonable? |
ah right, didn't think about the test not working 🤦 In this case my suggestion makes no sense. |
Fixes #90