Skip to content

chore: clean up pre horizon code#1016

Open
tmigone wants to merge 1 commit intotmigone/remove-v1-escrowfrom
tmigone/more-horizon-cleanup
Open

chore: clean up pre horizon code#1016
tmigone wants to merge 1 commit intotmigone/remove-v1-escrowfrom
tmigone/more-horizon-cleanup

Conversation

@tmigone
Copy link
Copy Markdown
Member

@tmigone tmigone commented Apr 17, 2026

1. Removed escrow_accounts_v1() dead code from monitor crate:

  • Deleted escrow_accounts_v1() function (~12 lines)
  • Deleted get_escrow_accounts_v1() function (~69 lines)
  • Deleted test_current_accounts() test (~46 lines)
  • Removed unused imports

2. Removed is_horizon_active() and simplified call sites:

  • Deleted crates/monitor/src/horizon_detection.rs (~53 lines) - this always returned Ok(true)
  • Updated crates/tap-agent/src/agent.rs - removed the horizon check wrapper
  • Updated crates/service/src/service.rs - removed the horizon check wrapper
  • Updated crates/monitor/src/lib.rs - removed module export

3. Updated outdated V1 comments and docs:

  • crates/service/src/tap.rs - Simplified receipt types documentation to only mention Horizon (V2)
  • crates/service/tests/router_test.rs - Removed mention of escrow subgraph (v1) in comment
  • crates/service/src/tap/receipt_store.rs - Renamed test from v1_and_v2_are_processed_successfully to
    receipts_are_processed_successfully
  • crates/monitor/src/escrow_accounts.rs - Updated test comment to just "Verify V2 escrow accounts are loaded correctly"

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone requested review from Maikol and MoonBoi9001 April 17, 2026 21:19
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24587100374

Warning

No base build found for commit 9f27d14 on tmigone/remove-v1-escrow.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 71.383%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 14778
Covered Lines: 10549
Line Coverage: 71.38%
Coverage Strength: 112.35 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants